Provide interface for using not at all supported alternative accounts. #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you rebase on master |
kashalls
force-pushed
the
prototype-alt-auth
branch
from
951e04f to
d1d2701
Compare
LucienHH
added a commit
to LucienHH/node-minecraft-protocol
that referenced
this pull request
Aug 19, 2022
commit af31ece Author: Romain Beaumont <[email protected]> Date: Tue Aug 16 01:00:53 2022 +0200 Release 1.36.0 commit 79afd27 Author: IceTank <[email protected]> Date: Tue Aug 16 00:57:47 2022 +0200 Fix unhandled promise rejection on ms auth (PrismarineJS#1022) commit d7c5053 Author: extremeheat <[email protected]> Date: Mon Aug 15 18:57:26 2022 -0400 1.19.0 support (PrismarineJS#1027) * Bump mcdata for 1.19 * 1.19 in version.js * 1.19.0 in ci yml * Update ci.yml * Update version.js * Update package.json * No fail fast * Update mcdata * Update package.json * Update ci.yml * [1.19] fix tests and library session code (PrismarineJS#1020) * make tests work, add todo's * clean up, varlong test, additional todo * removed log statements, fix for older versions * Update mcdata * Update ci.yml * Update ci.yml * remove excessive version comments near supportFeature checks Co-authored-by: Romain Beaumont <[email protected]> * chat signing implementation * Update ci.yml * move some boilerplate to pauth * update tests * update chat example * bump pauth, update doc * modify test nextMessage func * lint * update default version * add server player verifyMessage * update doc Co-authored-by: Romain Beaumont <[email protected]> Co-authored-by: Rob9315 <[email protected]> commit 60379eb Author: Jordan Jones <[email protected]> Date: Fri Jul 29 09:41:43 2022 -0700 Provide interface for using not at all supported alternative accounts. (PrismarineJS#1026) * Handle auth potentially being an function * "Simple" example of how in theroy it would work * Add package.json * Fix lint * add type declarations * Remove mcleaks example * Add doc changes * adjust warning * Fix lint from rebase manual edit. commit e079e9b Author: Jordan Jones <[email protected]> Date: Fri Jul 29 09:03:20 2022 -0700 Use offline mode as default authentication, fallback to offline mode if invalid option. (PrismarineJS#998) * Default n-m-p to use offline unless specified. * Remove expression * actually make offline default * Revert examples * Revert all example changes * Add deprecation warning that mojang servers are no longer accepting mojang auth tokens. commit e4c797d Author: Romain Beaumont <[email protected]> Date: Fri Jul 22 22:20:55 2022 +0200 Release 1.35.1 (PrismarineJS#1024) * Update HISTORY.md * Update package.json commit 92fd00d Author: Rob9315 <[email protected]> Date: Thu Jul 21 22:56:34 2022 +0200 add type values to packetTest (PrismarineJS#1023) * add varlong value to packetTest * add command_node type value in packetTest commit 446d1d9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jul 19 22:47:52 2022 +0200 Bump readable-stream from 3.6.0 to 4.1.0 (PrismarineJS#1014) Bumps [readable-stream](https://github.com/nodejs/readable-stream) from 3.6.0 to 4.1.0. - [Release notes](https://github.com/nodejs/readable-stream/releases) - [Commits](nodejs/readable-stream@v3.6.0...v4.1.0) --- updated-dependencies: - dependency-name: readable-stream dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 50de598 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jul 19 22:47:36 2022 +0200 Bump @types/node from 17.0.45 to 18.0.6 (PrismarineJS#1017) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.45 to 18.0.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6cc3cfc Author: Rob9315 <[email protected]> Date: Tue Jul 19 22:47:18 2022 +0200 add custom minecraft type `varlong` which aliases to varint (PrismarineJS#1018) * add custom minecraft type varlong which aliases to varint for now or forever * semicolon (standard-js)
LucienHH
added a commit
to LucienHH/node-minecraft-protocol
that referenced
this pull request
Aug 19, 2022
commit af31ece Author: Romain Beaumont <[email protected]> Date: Tue Aug 16 01:00:53 2022 +0200 Release 1.36.0 commit 79afd27 Author: IceTank <[email protected]> Date: Tue Aug 16 00:57:47 2022 +0200 Fix unhandled promise rejection on ms auth (PrismarineJS#1022) commit d7c5053 Author: extremeheat <[email protected]> Date: Mon Aug 15 18:57:26 2022 -0400 1.19.0 support (PrismarineJS#1027) * Bump mcdata for 1.19 * 1.19 in version.js * 1.19.0 in ci yml * Update ci.yml * Update version.js * Update package.json * No fail fast * Update mcdata * Update package.json * Update ci.yml * [1.19] fix tests and library session code (PrismarineJS#1020) * make tests work, add todo's * clean up, varlong test, additional todo * removed log statements, fix for older versions * Update mcdata * Update ci.yml * Update ci.yml * remove excessive version comments near supportFeature checks Co-authored-by: Romain Beaumont <[email protected]> * chat signing implementation * Update ci.yml * move some boilerplate to pauth * update tests * update chat example * bump pauth, update doc * modify test nextMessage func * lint * update default version * add server player verifyMessage * update doc Co-authored-by: Romain Beaumont <[email protected]> Co-authored-by: Rob9315 <[email protected]> commit 60379eb Author: Jordan Jones <[email protected]> Date: Fri Jul 29 09:41:43 2022 -0700 Provide interface for using not at all supported alternative accounts. (PrismarineJS#1026) * Handle auth potentially being an function * "Simple" example of how in theroy it would work * Add package.json * Fix lint * add type declarations * Remove mcleaks example * Add doc changes * adjust warning * Fix lint from rebase manual edit. commit e079e9b Author: Jordan Jones <[email protected]> Date: Fri Jul 29 09:03:20 2022 -0700 Use offline mode as default authentication, fallback to offline mode if invalid option. (PrismarineJS#998) * Default n-m-p to use offline unless specified. * Remove expression * actually make offline default * Revert examples * Revert all example changes * Add deprecation warning that mojang servers are no longer accepting mojang auth tokens. commit e4c797d Author: Romain Beaumont <[email protected]> Date: Fri Jul 22 22:20:55 2022 +0200 Release 1.35.1 (PrismarineJS#1024) * Update HISTORY.md * Update package.json commit 92fd00d Author: Rob9315 <[email protected]> Date: Thu Jul 21 22:56:34 2022 +0200 add type values to packetTest (PrismarineJS#1023) * add varlong value to packetTest * add command_node type value in packetTest commit 446d1d9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jul 19 22:47:52 2022 +0200 Bump readable-stream from 3.6.0 to 4.1.0 (PrismarineJS#1014) Bumps [readable-stream](https://github.com/nodejs/readable-stream) from 3.6.0 to 4.1.0. - [Release notes](https://github.com/nodejs/readable-stream/releases) - [Commits](nodejs/readable-stream@v3.6.0...v4.1.0) --- updated-dependencies: - dependency-name: readable-stream dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 50de598 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jul 19 22:47:36 2022 +0200 Bump @types/node from 17.0.45 to 18.0.6 (PrismarineJS#1017) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.45 to 18.0.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6cc3cfc Author: Rob9315 <[email protected]> Date: Tue Jul 19 22:47:18 2022 +0200 add custom minecraft type `varlong` which aliases to varint (PrismarineJS#1018) * add custom minecraft type varlong which aliases to varint for now or forever * semicolon (standard-js)
LucienHH
added a commit
to LucienHH/node-minecraft-protocol
that referenced
this pull request
Jan 15, 2023
commit af31ece Author: Romain Beaumont <[email protected]> Date: Tue Aug 16 01:00:53 2022 +0200 Release 1.36.0 commit 79afd27 Author: IceTank <[email protected]> Date: Tue Aug 16 00:57:47 2022 +0200 Fix unhandled promise rejection on ms auth (PrismarineJS#1022) commit d7c5053 Author: extremeheat <[email protected]> Date: Mon Aug 15 18:57:26 2022 -0400 1.19.0 support (PrismarineJS#1027) * Bump mcdata for 1.19 * 1.19 in version.js * 1.19.0 in ci yml * Update ci.yml * Update version.js * Update package.json * No fail fast * Update mcdata * Update package.json * Update ci.yml * [1.19] fix tests and library session code (PrismarineJS#1020) * make tests work, add todo's * clean up, varlong test, additional todo * removed log statements, fix for older versions * Update mcdata * Update ci.yml * Update ci.yml * remove excessive version comments near supportFeature checks Co-authored-by: Romain Beaumont <[email protected]> * chat signing implementation * Update ci.yml * move some boilerplate to pauth * update tests * update chat example * bump pauth, update doc * modify test nextMessage func * lint * update default version * add server player verifyMessage * update doc Co-authored-by: Romain Beaumont <[email protected]> Co-authored-by: Rob9315 <[email protected]> commit 60379eb Author: Jordan Jones <[email protected]> Date: Fri Jul 29 09:41:43 2022 -0700 Provide interface for using not at all supported alternative accounts. (PrismarineJS#1026) * Handle auth potentially being an function * "Simple" example of how in theroy it would work * Add package.json * Fix lint * add type declarations * Remove mcleaks example * Add doc changes * adjust warning * Fix lint from rebase manual edit. commit e079e9b Author: Jordan Jones <[email protected]> Date: Fri Jul 29 09:03:20 2022 -0700 Use offline mode as default authentication, fallback to offline mode if invalid option. (PrismarineJS#998) * Default n-m-p to use offline unless specified. * Remove expression * actually make offline default * Revert examples * Revert all example changes * Add deprecation warning that mojang servers are no longer accepting mojang auth tokens. commit e4c797d Author: Romain Beaumont <[email protected]> Date: Fri Jul 22 22:20:55 2022 +0200 Release 1.35.1 (PrismarineJS#1024) * Update HISTORY.md * Update package.json commit 92fd00d Author: Rob9315 <[email protected]> Date: Thu Jul 21 22:56:34 2022 +0200 add type values to packetTest (PrismarineJS#1023) * add varlong value to packetTest * add command_node type value in packetTest commit 446d1d9 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jul 19 22:47:52 2022 +0200 Bump readable-stream from 3.6.0 to 4.1.0 (PrismarineJS#1014) Bumps [readable-stream](https://github.com/nodejs/readable-stream) from 3.6.0 to 4.1.0. - [Release notes](https://github.com/nodejs/readable-stream/releases) - [Commits](nodejs/readable-stream@v3.6.0...v4.1.0) --- updated-dependencies: - dependency-name: readable-stream dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 50de598 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Jul 19 22:47:36 2022 +0200 Bump @types/node from 17.0.45 to 18.0.6 (PrismarineJS#1017) Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 17.0.45 to 18.0.6. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6cc3cfc Author: Rob9315 <[email protected]> Date: Tue Jul 19 22:47:18 2022 +0200 add custom minecraft type `varlong` which aliases to varint (PrismarineJS#1018) * add custom minecraft type varlong which aliases to varint for now or forever * semicolon (standard-js)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an interface for the people desperate enough not wanting to spend money on a good game (that was until Microsoft got their grubby hands on it) to use alternative services to allow game play. I cannot heed this enough that using these alternative services may or may not get you into trouble. Do not hold me accountable.
This provides a solution for: PrismarineJS/mineflayer#1116, PrismarineJS/mineflayer#1331, PrismarineJS/mineflayer#790, #736, #1025 and a bunch more that I am not bothering to look for.
This proposal is to check if the user has specified a function for
options.authrather thanmojang|microsoft. If it is a function, we let that function handle setting the username, accessToken... making any related api calls. However, when it comes to joining, if they are not using the official session server, they will have to create a local proxy to convert the expected format that usually is sent to mojang's session server to their custom auth server.